ip_flow.c ipf struct member ipf_start

[Liam J. Foy]

hi,

i appreciate this is only a minor nit. however...

ip_flow.c contains the struct ipf which in turn contains a member
called ipf_start. this member is never used (only assigned, never
read) and I can't see a time it ever was. i was going to remove it but
another developer pointed out it might have been used for debugging
but no one knows.

i propose to remove it completely or #ifdef the member.

any comments?

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[David Young]

Post by Liam J. Foy
hi,
i appreciate this is only a minor nit. however...
ip_flow.c contains the struct ipf which in turn contains a member
called ipf_start. this member is never used (only assigned, never
read) and I can't see a time it ever was. i was going to remove it but
another developer pointed out it might have been used for debugging
but no one knows.
i propose to remove it completely or #ifdef the member.

I think that if nobody chimes in soon with a use for it, you should
delete it.

Please, whatever you do, don't #ifdef it!

Dave

[Bernd Ernesti]

Post by Liam J. Foy
hi,
i appreciate this is only a minor nit. however...
ip_flow.c contains the struct ipf which in turn contains a member
called ipf_start. this member is never used (only assigned, never
read) and I can't see a time it ever was. i was going to remove it but
another developer pointed out it might have been used for debugging
but no one knows.
i propose to remove it completely or #ifdef the member.
any comments?

Where is the issue with the member and what is FreeBSD using?

Bernd



--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[Liam J. Foy]

Post by Bernd Ernesti

Post by Liam J. Foy
hi,
i appreciate this is only a minor nit. however...
ip_flow.c contains the struct ipf which in turn contains a member
called ipf_start. this member is never used (only assigned, never
read) and I can't see a time it ever was. i was going to remove it but
another developer pointed out it might have been used for debugging
but no one knows.
i propose to remove it completely or #ifdef the member.
any comments?

Where is the issue with the member and what is FreeBSD using?
Bernd

Hi Bernd,

The issue was minor - it wasn't used.

FreeBSD now have another implementation entirely.

Regards,