CVS commit: src/sys/netinet

[YAMAMOTO Takashi]

hi,

Module Name: src
Committed By: tls
Date: Thu Apr 1 00:24:41 UTC 2010
src/sys/netinet: ip_flow.c tcp_input.c
the driver output path (that is, ifp->if_output()). In the case of
entry through the socket code, we are fine, because pru_usrreq takes
KERNEL_LOCK. However, there are a few other ways to cause output
1) direct calls to tcp_output() in tcp_input()
2) fast-forwarding code (ip_flow) -- protected elsewise
against itself by the softnet lock.
3) *Possibly* the ARP code. I have currently persuaded
myself that it is safe because of how it's called.
4) Possibly the ICMP code.
This change addresses #1 and #2.

what's the status of the rest?

it seems that ip_forward() at least still has the problem.

YAMAMOTO Takashi

cvs rdiff -u -r1.58 -r1.59 src/sys/netinet/ip_flow.c
cvs rdiff -u -r1.300 -r1.301 src/sys/netinet/tcp_input.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[Thor Lancelot Simon]

Post by YAMAMOTO Takashi
hi,

KERNEL_LOCK. However, there are a few other ways to cause output
1) direct calls to tcp_output() in tcp_input()
2) fast-forwarding code (ip_flow) -- protected elsewise
against itself by the softnet lock.
3) *Possibly* the ARP code. I have currently persuaded
myself that it is safe because of how it's called.
4) Possibly the ICMP code.

what's the status of the rest?
it seems that ip_forward() at least still has the problem.

I still think the ARP code is OK. I have not seen problems resulting
from the ICMP code but have not given it any more careful study. We're
using the result of the KERNEL_LOCK change you reference above, pulled
up into our local netbsd-5 tree, in production and haven't seen any
obvious problems. If you see anything that appears wrong along these
lines, though, by all means, please fix it!

Thor

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de