Review of pfs(8)

[Arnaud Degroote]

Hi,

I would like to integrate pfs(8) into the main tree. pfs is a tool similar as
ipfs(8) but for the pf(4) filtering solution, aka it lets the administrator
dumps the current internal state table of pf, reboot for maintenance, and loads
the saved table into pf, in a tranparent way for users.

I attach the current version of the code in attachment. If there are no comment,
I will push it to main tree next week.

Best regards,

[Christos Zoulas]

-=-=-=-=-=-
Hi,
I would like to integrate pfs(8) into the main tree. pfs is a tool similar as
ipfs(8) but for the pf(4) filtering solution, aka it lets the administrator
dumps the current internal state table of pf, reboot for maintenance, and loads
the saved table into pf, in a tranparent way for users.
I attach the current version of the code in attachment. If there are no comment,
I will push it to main tree next week.

- Add copyrights.
- The switch indentation is not KNF.

Nicely done,

christos


--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[Arnaud Degroote]

Post by Christos Zoulas

Post by Arnaud Degroote
Hi,
I would like to integrate pfs(8) into the main tree. pfs is a tool similar as
ipfs(8) but for the pf(4) filtering solution, aka it lets the administrator
dumps the current internal state table of pf, reboot for maintenance, and loads
the saved table into pf, in a tranparent way for users.
I attach the current version of the code in attachment. If there are no comment,
I will push it to main tree next week.

- Add copyrights.
- The switch indentation is not KNF.

I have updated the patch on
http://ftp.netbsd.org/pub/NetBSD/misc/degroote/pfs.diff fixing the two issues
you noted and adding RCSID stuff.

[Christos Zoulas]

Post by Arnaud Degroote

Post by Christos Zoulas

Post by Arnaud Degroote
Hi,
I would like to integrate pfs(8) into the main tree. pfs is a tool similar as
ipfs(8) but for the pf(4) filtering solution, aka it lets the administrator
dumps the current internal state table of pf, reboot for maintenance,

and loads

Post by Christos Zoulas

Post by Arnaud Degroote
the saved table into pf, in a tranparent way for users.
I attach the current version of the code in attachment. If there are

no comment,

Post by Christos Zoulas

Post by Arnaud Degroote
I will push it to main tree next week.

- Add copyrights.
- The switch indentation is not KNF.

I have updated the patch on
http://ftp.netbsd.org/pub/NetBSD/misc/degroote/pfs.diff fixing the two issues
you noted and adding RCSID stuff.

great, buf[100] can be overrun, right?

christos


--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[Arnaud Degroote]

Post by Christos Zoulas

Post by Arnaud Degroote

Post by Christos Zoulas

Post by Arnaud Degroote
Hi,
I would like to integrate pfs(8) into the main tree. pfs is a tool similar as
ipfs(8) but for the pf(4) filtering solution, aka it lets the administrator
dumps the current internal state table of pf, reboot for maintenance,

and loads

Post by Christos Zoulas

Post by Arnaud Degroote
the saved table into pf, in a tranparent way for users.
I attach the current version of the code in attachment. If there are

no comment,

Post by Christos Zoulas

Post by Arnaud Degroote
I will push it to main tree next week.

- Add copyrights.
- The switch indentation is not KNF.

I have updated the patch on
http://ftp.netbsd.org/pub/NetBSD/misc/degroote/pfs.diff fixing the two issues
you noted and adding RCSID stuff.

great, buf[100] can be overrun, right?

You are right, I add some protection against ill-formed sequence (buf must
contain string representation of int32_t).