carp on vlan: drop M_PROMISC before calling carp ?

[Manuel Bouyer]

Hi,
trying to run carp interfaces on top of vlan interfaces I ran into
an issue: the packets for the carp interface are just dropped, they
never make it to the upper layer. I traked it down to the vlan interface
forwarding the packet to carp with M_PROMISC set, which is still here
when carp calls ether_input() again. This is a problem that also existed
for bridges; I applied the same fix: drop M_PROMISC before calling carp.
This works, and I also checked that when the carp interface is in BACKUP
state the packet is dropped. Does the attached patch make sense ?

[Manuel Bouyer]

Post by Manuel Bouyer
Hi,
trying to run carp interfaces on top of vlan interfaces I ran into
an issue: the packets for the carp interface are just dropped, they
never make it to the upper layer. I traked it down to the vlan interface
forwarding the packet to carp with M_PROMISC set, which is still here
when carp calls ether_input() again. This is a problem that also existed
for bridges; I applied the same fix: drop M_PROMISC before calling carp.
This works, and I also checked that when the carp interface is in BACKUP
state the packet is dropped. Does the attached patch make sense ?

I'm running a system with carp on vlan for several days now;
I just commited it to current and will request a pullup to netbsd-4 in
a few days.

[Liam J. Foy]

Post by Manuel Bouyer
Hi,
trying to run carp interfaces on top of vlan interfaces I ran into
an issue: the packets for the carp interface are just dropped, they
never make it to the upper layer. I traked it down to the vlan
interface
forwarding the packet to carp with M_PROMISC set, which is still here
when carp calls ether_input() again. This is a problem that also existed
for bridges; I applied the same fix: drop M_PROMISC before calling carp.
This works, and I also checked that when the carp interface is in BACKUP
state the packet is dropped. Does the attached patch make sense ?
--
NetBSD: 26 ans d'experience feront toujours la difference
--
<diff>

Yeah, it seems fine to me

---
Liam J. Foy
<***@netbsd.org>



--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de