Discussion:
Pushing down kauth(9) calls in netinet{,6}
(too old to reply)
Elad Efrat
2009-04-30 22:57:34 UTC
Permalink
Hi,

Attached diff pushes down some kauth(9) calls closer to where their
return value is used.

I've changed some curlwp->l_cred to kauth_cred_get(), functions now
pass credentials instead of a variable that says if the caller is
privileged or not, etc.

Please review.

Thanks,

-e.
David Young
2009-05-10 00:16:28 UTC
Permalink
Post by Elad Efrat
Hi,
Attached diff pushes down some kauth(9) calls closer to where their
return value is used.
I've changed some curlwp->l_cred to kauth_cred_get(), functions now
pass credentials instead of a variable that says if the caller is
privileged or not, etc.
Please review.
This change breaks FAST_IPSEC. Compile again with this kernel
configuration, and I think that you will see what I mean:

include "arch/i386/conf/GENERIC"

options GATEWAY # packet forwarding
options FAST_IPSEC # IP security

Dave
--
David Young OJC Technologies
***@ojctech.com Urbana, IL * (217) 278-3933

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Elad Efrat
2009-05-10 02:14:29 UTC
Permalink
Post by David Young
This change breaks FAST_IPSEC. Compile again with this kernel
include "arch/i386/conf/GENERIC"
options GATEWAY # packet forwarding
options FAST_IPSEC # IP security
Fixed, thanks.

As a side note, we should really have more than one ALL kernel if there
are mutually exclusive kernel options, so we can at least cover all
ground in compile-tests.

-e.

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Loading...