Discussion:
please test: ethernet media-handling patch
(too old to reply)
David Young
2008-01-10 08:32:00 UTC
Permalink
At <ftp://cuw.ojctech.com/users/dyoung-3ed84044/ifmedia.patch> is a
patch that makes many ethernet drivers share the common code for MII
media handling, ether_mediastatus() and ether_mediachange(), and which
checks for a non-ENXIO error return from mii_mediachg().

I want everyone to have the opportunity to test this patch before I
commit it in about a week, because it affects more architectures than
I can feasibly compile and run.

The patch contains a few miscellaneous changes, too:

gem(4): use LIST_EMPTY(), LIST_FOREACH().
mtd(4): handle media ioctls, for a change!
axe(4): do not track link status in sc->axe_link any longer
nfe(4), aue(4), axe(4), udav(4), url(4): do not reset all PHYs
on a change of media

I have compiled macppc, sparc64, and i386. I am compiling for evbmips
(MERAKI), now. I have run the patches on i386 boxen with bnx(4)
and sip(4).

Dave
--
David Young OJC Technologies
***@ojctech.com Urbana, IL * (217) 278-3933 ext 24

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Ignatios Souvatzis
2008-01-10 21:46:35 UTC
Permalink
So if I unplug a cable from a 100M network and put it into a 1G
network, it won't reset and renegotiate? (Forgive me if I don't
understand this properly.)
If the operator changes the media settings,
Ah. Okay, this was just me being dense then.
I don't think so. The patch does deserve a test on the actual hardware,
and that is why I did not commit it outright. Somebody thought that it
the code. I don't think that it matters, since mii_media_chg() will reset
or configure every PHY, but I hope that someone with the h/w will test.
I'm not sure I understand. When I just plug out the cable from
the laptop, go to the other lab, and plug in - will the driver
notice that it has to renegotiate even with your changes?

-is
--
seal your e-mail: http://www.gnupg.org/

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
David Young
2008-01-10 21:57:39 UTC
Permalink
Post by Ignatios Souvatzis
So if I unplug a cable from a 100M network and put it into a 1G
network, it won't reset and renegotiate? (Forgive me if I don't
understand this properly.)
If the operator changes the media settings,
Ah. Okay, this was just me being dense then.
I don't think so. The patch does deserve a test on the actual hardware,
and that is why I did not commit it outright. Somebody thought that it
the code. I don't think that it matters, since mii_media_chg() will reset
or configure every PHY, but I hope that someone with the h/w will test.
I'm not sure I understand. When I just plug out the cable from
the laptop, go to the other lab, and plug in - will the driver
notice that it has to renegotiate even with your changes?
Yes.

It is not my intention to change the way any driver works, just to share
code and to simplify code.

If my patch affects a driver that you depend on, I ask that you please
test the patch.

Dave
--
David Young OJC Technologies
***@ojctech.com Urbana, IL * (217) 278-3933 ext 24

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Loading...