Discussion:
Refactoring Congestion Control
(too old to reply)
Rui Paulo
2006-09-17 20:17:53 UTC
Permalink
Hi,
Me and Kentaro had the same idea of refactoring the congestion
control algorithms to make them mode modular. (We could, for
instance, program TCP/Westwood+ and TCP/Daytona more easily).
Turns out he already did the work for an old NetBSD version.
I grabbed the patch and updated it to -current.

Any comments before I commit ?

-- Rui Paulo
Hubert Feyrer
2006-09-17 21:13:56 UTC
Permalink
Post by Rui Paulo
Any comments before I commit ?
Where is the documentation or at least a design document?


- Hubert

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Rui Paulo
2006-09-17 21:35:52 UTC
Permalink
Post by Hubert Feyrer
Post by Rui Paulo
Any comments before I commit ?
Where is the documentation or at least a design document?
There's no need for such thing.


-- Rui Paulo



--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Hubert Feyrer
2006-09-17 21:34:31 UTC
Permalink
Post by Rui Paulo
Post by Hubert Feyrer
Where is the documentation or at least a design document?
There's no need for such thing.
Serious, can you describe what the code does?


- Hubert

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Rui Paulo
2006-09-17 21:46:55 UTC
Permalink
Post by Hubert Feyrer
Post by Rui Paulo
Post by Hubert Feyrer
Where is the documentation or at least a design document?
There's no need for such thing.
Serious, can you describe what the code does?
Ok. The code is the heart of the congestion control in our TCP stack.
I'm moving stuff around and creating a new "class" a-la objective
programming (in this case a struct with three function pointers).
This way we can separate the congestion control algorithms we have in
our source tree.
Basically with this we should be able to remove the checks for if
(tcp_newreno) or if (tcp_westwood), etc.
Note that I'm not adding new code, hence the subject "refactoring".

-- Rui Paulo



--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Christos Zoulas
2006-09-17 21:35:52 UTC
Permalink
-=-=-=-=-=-
Hi,
Me and Kentaro had the same idea of refactoring the congestion
control algorithms to make them mode modular. (We could, for
instance, program TCP/Westwood+ and TCP/Daytona more easily).
Turns out he already did the work for an old NetBSD version.
I grabbed the patch and updated it to -current.
Any comments before I commit ?
-- Rui Paulo
-=-=-=-=-=-
[Attachment type=application/octet-stream, name=tcp_congctrl.diff]
-=-=-=-=-=-
Looks ok to me, can you also write a man page for the api?

christos


--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Rui Paulo
2006-09-17 21:47:32 UTC
Permalink
Post by Christos Zoulas
Looks ok to me, can you also write a man page for the api?
Okay, I'll do that.
Thanks for the review.

-- Rui Paulo



--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Loading...