XEN bpf panic

Roy Marples

2018-01-19 18:44:27 UTC

Post by Roy Marples
My -current ish XEN DOMU's randomly panic.
panic: kernel diagnostic assertion "!cpu_intr_p()" failed: file
"/home/roy/src/src/sys/net/bpf.c", line 1581
https://nxr.netbsd.org/xref/src/sys/net/bpf.c#1581
KASSERT(!cpu_intr_p());
The rests of the trace looks like this (had to use addr2line)
xennet_softstart
/home/roy/src/src/sys/arch/xen/xen/if_xennet_xenbus.c:?
xennet_handler
/home/roy/src/src/sys/arch/xen/xen/if_xennet_xenbus.c:?
xen_intr_biglock_wrapper
??:?
evtchn_do_event
??:?
do_hypervisor_callback
??:?
hypervisor_callback
Is this enough information for some bright spark to fix?

riastradh@ proposed this patch which I have my DOMU's now running.

Index: sys/arch/xen/xen/if_xennet_xenbus.c
===================================================================
RCS file: /cvsroot/src/sys/arch/xen/xen/if_xennet_xenbus.c,v
retrieving revision 1.73
diff -p -u -r1.73 if_xennet_xenbus.c
--- sys/arch/xen/xen/if_xennet_xenbus.c 11 Nov 2017 21:03:01 -0000 1.73
+++ sys/arch/xen/xen/if_xennet_xenbus.c 19 Jan 2018 18:28:02 -0000
@@ -956,7 +956,7 @@ again:
end:
if (ifp->if_flags & IFF_OACTIVE) {
ifp->if_flags &= ~IFF_OACTIVE;
- xennet_softstart(sc);
+ softint_schedule(sc->sc_softintr);
}
}

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de