tcp_output fix for acking with a full send buffer

[Darrin B.Jewell]

A while ago, I encountered a bug where I could get tcp to slow down
because it couldn't get acks on the wire. I tracked this down to
mycroft's original fix to avoid sending more than half a buffer full.

The fix is to never send more than (hiwat - lowat + 1)/2 instead of
mycroft's fix of just hiwat/2. I've had a patch in my tree for some
time, but haven't had the time to write up a simplified test case
demonstrating the problem.

Does the following patch look correct?

Thanks,
Darrin

[Bill Studenmund]

Post by Darrin B.Jewell
A while ago, I encountered a bug where I could get tcp to slow down
because it couldn't get acks on the wire. I tracked this down to
mycroft's original fix to avoid sending more than half a buffer full.
The fix is to never send more than (hiwat - lowat + 1)/2 instead of
mycroft's fix of just hiwat/2. I've had a patch in my tree for some
time, but haven't had the time to write up a simplified test case
demonstrating the problem.
Does the following patch look correct?

Looks good!

Take care,

Bill

[Jason Thorpe]

Post by Darrin B.Jewell
A while ago, I encountered a bug where I could get tcp to slow down
because it couldn't get acks on the wire. I tracked this down to
mycroft's original fix to avoid sending more than half a buffer full.
The fix is to never send more than (hiwat - lowat + 1)/2 instead of
mycroft's fix of just hiwat/2. I've had a patch in my tree for some
time, but haven't had the time to write up a simplified test case
demonstrating the problem.
Does the following patch look correct?

Please get this pulled up to netbsd-4, as well. (and netbsd-3, if the
patch is applicable there)

Post by Darrin B.Jewell
Thanks,
Darrin
<tcpoutput.diff>

-- thorpej


--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de