Discussion:
removal of bpf_tap() (not bpf_mtap)
(too old to reply)
Masanobu SAITOH
2018-06-22 09:50:47 UTC
Permalink
Hi.

The following two changes removed bpf_tap() which uses linear data
instead of mbuf:

http://mail-index.netbsd.org/source-changes/2018/06/22/msg096214.html
http://mail-index.netbsd.org/source-changes/2018/06/22/msg096215.html

Only above two drivers used bpf_tap(). There is no any driver
which use it now. Is it OK to remove from bpf.[ch]?
--
-----------------------------------------------
SAITOH Masanobu (***@execsw.org
***@netbsd.org)

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Jason Thorpe
2018-06-22 15:10:02 UTC
Permalink
Post by Masanobu SAITOH
Hi.
The following two changes removed bpf_tap() which uses linear data
http://mail-index.netbsd.org/source-changes/2018/06/22/msg096214.html
http://mail-index.netbsd.org/source-changes/2018/06/22/msg096215.html
Only above two drivers used bpf_tap(). There is no any driver
which use it now. Is it OK to remove from bpf.[ch]?
Seems fine to me. It's trivial to wrap a linear buffer in an mbuf if needed.
Post by Masanobu SAITOH
--
-----------------------------------------------
-- thorpej


--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Masanobu SAITOH
2018-06-25 03:25:49 UTC
Permalink
Post by Jason Thorpe
Post by Masanobu SAITOH
Hi.
The following two changes removed bpf_tap() which uses linear data
http://mail-index.netbsd.org/source-changes/2018/06/22/msg096214.html
http://mail-index.netbsd.org/source-changes/2018/06/22/msg096215.html
Only above two drivers used bpf_tap(). There is no any driver
which use it now. Is it OK to remove from bpf.[ch]?
Seems fine to me. It's trivial to wrap a linear buffer in an mbuf if needed.
Removed.

Thanks.
Post by Jason Thorpe
Post by Masanobu SAITOH
--
-----------------------------------------------
-- thorpej
--
-----------------------------------------------
SAITOH Masanobu (***@execsw.org
***@netbsd.org)

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Loading...