Discussion:
bridge(4)
(too old to reply)
Robert Swindells
2015-07-31 15:27:41 UTC
Permalink
Please could someone try the following patch.

The deleted line shouldn't be doing anything useful in normal usage
plus I think it can confuse wireless devices that are members of the
bridge.

Robert Swindells

Index: if_bridge.c
===================================================================
RCS file: /cvsroot/src/sys/net/if_bridge.c,v
retrieving revision 1.100
diff -u -r1.100 if_bridge.c
--- if_bridge.c 23 Jul 2015 10:52:34 -0000 1.100
+++ if_bridge.c 31 Jul 2015 15:23:18 -0000
@@ -1512,7 +1512,6 @@
#endif /* ALTQ */

len = m->m_pkthdr.len;
- m->m_flags |= M_PROTO1;
mflags = m->m_flags;

IFQ_ENQUEUE(&dst_ifp->if_snd, m, &pktattr, error);

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Ryota Ozaki
2015-08-10 03:33:13 UTC
Permalink
Hi,
Post by Robert Swindells
Please could someone try the following patch.
The deleted line shouldn't be doing anything useful in normal usage
plus I think it can confuse wireless devices that are members of the
bridge.
I think you're right. It seems M_PROTO1 was introduced for gif(4),
but after gif(4) update, M_PROTO1 became unnecessary.

The change doesn't break ATF tests. Let's commit it.
ozaki-r
Post by Robert Swindells
Robert Swindells
Index: if_bridge.c
===================================================================
RCS file: /cvsroot/src/sys/net/if_bridge.c,v
retrieving revision 1.100
diff -u -r1.100 if_bridge.c
--- if_bridge.c 23 Jul 2015 10:52:34 -0000 1.100
+++ if_bridge.c 31 Jul 2015 15:23:18 -0000
@@ -1512,7 +1512,6 @@
#endif /* ALTQ */
len = m->m_pkthdr.len;
- m->m_flags |= M_PROTO1;
mflags = m->m_flags;
IFQ_ENQUEUE(&dst_ifp->if_snd, m, &pktattr, error);
--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Loading...