Discussion:
small code duplication reduction patch
(too old to reply)
Tyler Retzlaff
2016-02-14 22:51:54 UTC
Permalink
hi,

the attached patch splits out a new function in6_in_2_v4mapin6() for
creating IPv4-Maped IPv6 addresses from IPv4 addresses from the
existing in6_sin_2_v4mapsin6()

the remainder of the patch replaces redundant code which uses either
the new in6_in_2_v4mapin6() (for dealing with in{,6}_addr) or
existing in6_sin_2_v4mapsin6() (for dealing with sockaddr_in{,6})

no functional change intended, unless there are problems i'll
commit in the next day or two.

thanks
Christos Zoulas
2016-02-15 00:30:13 UTC
Permalink
-=-=-=-=-=-
hi,
the attached patch splits out a new function in6_in_2_v4mapin6() for
creating IPv4-Maped IPv6 addresses from IPv4 addresses from the
existing in6_sin_2_v4mapsin6()
the remainder of the patch replaces redundant code which uses either
the new in6_in_2_v4mapin6() (for dealing with in{,6}_addr) or
existing in6_sin_2_v4mapsin6() (for dealing with sockaddr_in{,6})
no functional change intended, unless there are problems i'll
commit in the next day or two.
LGTM.

christos


--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Joerg Sonnenberger
2016-02-15 16:33:44 UTC
Permalink
Post by Tyler Retzlaff
the attached patch splits out a new function in6_in_2_v4mapin6() for
creating IPv4-Maped IPv6 addresses from IPv4 addresses from the
existing in6_sin_2_v4mapsin6()
Hm. I only dislike the name. Why not inet2inet6 or so?

Joerg

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Tyler Retzlaff
2016-02-15 16:47:00 UTC
Permalink
Post by Joerg Sonnenberger
Post by Tyler Retzlaff
the attached patch splits out a new function in6_in_2_v4mapin6() for
creating IPv4-Maped IPv6 addresses from IPv4 addresses from the
existing in6_sin_2_v4mapsin6()
Hm. I only dislike the name. Why not inet2inet6 or so?
I don't like the name either but I matched the name to the functions
already in the file for consistency. :/
Post by Joerg Sonnenberger
Joerg
--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Loading...