kernel diagnostic assertion "llt != NULL" failed

[Manuel Bouyer]

Hello,
on a netbsd-8 system, running with a netbsd-5 userland so the ipv4 stack
was probably not fully initialised (some network-related commands fails
with "Protocol not supported"), I got at shutdown:
panic: kernel diagnostic assertion "llt != NULL" failed: file "/dsk/l1/misc/bouyer/netbsdtsar/netbsd-8/src/sys/net/if_llatbl.c", line 427 llt is NULL

unfortunably I couldn't get a stack trace.
Changing this KASSERT to
if (llt == NULL) {
printf("llt is NULL\n");
return;
}

allows for a clean shutdown in my case.
Is this correct ?

[Ryota Ozaki]

Post by Manuel Bouyer
Hello,
on a netbsd-8 system, running with a netbsd-5 userland so the ipv4 stack
was probably not fully initialised (some network-related commands fails
panic: kernel diagnostic assertion "llt != NULL" failed: file "/dsk/l1/misc/bouyer/netbsdtsar/netbsd-8/src/sys/net/if_llatbl.c", line 427 llt is NULL
unfortunably I couldn't get a stack trace.
Changing this KASSERT to
if (llt == NULL) {
printf("llt is NULL\n");
return;
}
allows for a clean shutdown in my case.
Is this correct ?

It also works but the following fix might be better.
Could you try the diff?

Thanks,
ozaki-r


diff --git a/sys/netinet/in.c b/sys/netinet/in.c
index 09e091b6774..1ace5e88fb6 100644
--- a/sys/netinet/in.c
+++ b/sys/netinet/in.c
@@ -1539,7 +1539,9 @@ in_if_down(struct ifnet *ifp)
{

in_if_link_down(ifp);
+#if NARP > 0
lltable_purge_entries(LLTABLE(ifp));
+#endif
}

void

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[Manuel Bouyer]

Post by Ryota Ozaki

Post by Manuel Bouyer
Hello,
on a netbsd-8 system, running with a netbsd-5 userland so the ipv4 stack
was probably not fully initialised (some network-related commands fails
panic: kernel diagnostic assertion "llt != NULL" failed: file "/dsk/l1/misc/bouyer/netbsdtsar/netbsd-8/src/sys/net/if_llatbl.c", line 427 llt is NULL
unfortunably I couldn't get a stack trace.
Changing this KASSERT to
if (llt == NULL) {
printf("llt is NULL\n");
return;
}
allows for a clean shutdown in my case.
Is this correct ?

It also works but the following fix might be better.
Could you try the diff?

Yes, it fixes the problem too.
thanks !

[Ryota Ozaki]

Post by Manuel Bouyer

Post by Ryota Ozaki

Post by Manuel Bouyer
Hello,
on a netbsd-8 system, running with a netbsd-5 userland so the ipv4 stack
was probably not fully initialised (some network-related commands fails
panic: kernel diagnostic assertion "llt != NULL" failed: file "/dsk/l1/misc/bouyer/netbsdtsar/netbsd-8/src/sys/net/if_llatbl.c", line 427 llt is NULL
unfortunably I couldn't get a stack trace.
Changing this KASSERT to
if (llt == NULL) {
printf("llt is NULL\n");
return;
}
allows for a clean shutdown in my case.
Is this correct ?

It also works but the following fix might be better.
Could you try the diff?

Yes, it fixes the problem too.
thanks !

Thank you for testing!
ozaki-r

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de