PPPoE: use random hunique

[Maxime Villard]

Currently, the HostUnique we send over the network is the memory address of the
active softc structure. That's dumb, as I said in TODO.kaslr.

Here is a patch [1] that fixes that: we generate a random uint64_t when a softc
structure is created, and we send this id as HostUnique.

Can someone test quickly? I know there are PPPoE users, but I don't use PPPoE
myself...

Thanks,
Maxime

[1] http://m00nbsd.net/garbage/net/pppoerand.diff

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[Martin Husemann]

Post by Maxime Villard
Can someone test quickly? I know there are PPPoE users, but I don't use PPPoE
myself...

You just need to:

cd /usr/tests/net/if_pppoe
atf-run | atf-report

with the patch applied and a full build done.

Martin

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de