kauth(9) call inside splnet() in if_bridge.c

[Elad Efrat]

Hi,

Attached is a diff to move the kauth(9) call in if_bridge.c outside the
splnet() surrounded code.

IIUC, this is something we're interested in, please review. :)

Thanks,

-e.

[Quentin Garnier]

Index: if_bridge.c
===================================================================
RCS file: /cvsroot/src/sys/net/if_bridge.c,v
retrieving revision 1.68
diff -u -p -r1.68 if_bridge.c
--- if_bridge.c 4 Apr 2009 15:53:49 -0000 1.68
+++ if_bridge.c 8 May 2009 14:38:48 -0000
@@ -445,9 +445,27 @@ bridge_ioctl(struct ifnet *ifp, u_long c
struct ifbrparam ifbrparam;
} args;
struct ifdrv *ifd = (struct ifdrv *) data;
- const struct bridge_control *bc;
+ const struct bridge_control *bc = NULL; /* XXXGCC */
int s, error = 0;
+ /* Authorize command before calling splnet(). */
+ switch (cmd) {
+ bc = &bridge_control_table[ifd->ifd_cmd];
+
+ /* We only care about BC_F_SUSER at this point. */
+ if ((bc->bc_flags & BC_F_SUSER) == 0)

We're certainly not interested in skipping the test for ifd_cmd's
validity.

I hope you've been more careful for all the commits you've done the
past couple weeks.

[Elad Efrat]

Post by Quentin Garnier
We're certainly not interested in skipping the test for ifd_cmd's
validity.

Sorry, forgot to cut & paste another part of the code -- fixed now, thanks.

Anything else?

-e.

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de