Discussion:
[PATCH] invalidate pointers right after pool_put()
(too old to reply)
Mindaugas Rasiukevicius
2009-04-28 13:35:03 UTC
Permalink
attached patch invalidates pointers right after pool_put().
I'm running a machine with this patch for several month
w/o any problems.
Is it ok to commit?
The kmem(9) and pool(9) subsystems already perform use-after-free checking
in debug/diagnostic kernels. I do not think there is a benefit in such patch,
and rtfree() part is especially ugly. What are you trying to solve?
--
Best regards,
Mindaugas

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Manuel Bouyer
2009-04-28 17:34:23 UTC
Permalink
Post by Mindaugas Rasiukevicius
attached patch invalidates pointers right after pool_put().
I'm running a machine with this patch for several month
w/o any problems.
Is it ok to commit?
The kmem(9) and pool(9) subsystems already perform use-after-free checking
in debug/diagnostic kernels. I do not think there is a benefit in such patch,
especially as in several place it zero out the local pointer but not
the one in the referencing structure or calling function, which is
more likely to perform a use after free than a local variable.
--
Manuel Bouyer <***@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de
Loading...